Jobs List Screen Design #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 7b893a3 |
vanshg
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Thank you for reorganizing this
Comment on lines
+61
to
+62
| #if DEBUG | ||
| extension JobData { |
Merged
tobitech
added a commit
that referenced
this pull request
Jul 16, 2024
* Jobs List Screen Design (#184) * change folder structure. add smileid theme background to the jobs screen. * add icon computed property to the job type * design implementation for empty state view * move reusable views into components group * add background and spacers to empty state view * code formatting * make user id and job id copyable. * expand job item when container is tapped * Task Core Data Setup (#185) * change folder structure. add smileid theme background to the jobs screen. * add icon computed property to the job type * design implementation for empty state view * move reusable views into components group * some project restructuring * add core data model file to the project. define an entity for job and add configure its attributes. generate model class * setup core data stack with persistent container and save and delete model object functionalities. * add an error model * setup core data stack with preview version. add create function to the job managed object. * implement new static functions for fetching jobs and saving new jobs. * add update and delete jobs static functions * code formatting. * model target changes. * change path of xcdatamodel file in pbxproj file. * move model file back to models group. * remove hard coded path * Task Save and Fetch Jobs (#186) * add a view model for jobs view and a provider to handle data store. * add a confirmation to clear jobs action. * save information from successful jobs in the corresponding delegate methods. * some code formatting * specify todos - to be removed after clarification. * move the creation of user id and job id to HomeViewModel and pass the values into the different jobs screen. * code formatting. * update job complete for smart selfie authentication * Task Update Jobs Status (#192) * improve error handling for functionalities using the data store. introduce new model to handle updating each job status. * update all the necessary details of a job stored locally from the api response. * code formatting * update job element model * Sort Jobs List and Fix Job Status Update Issue (#194) * change job timestamp to date type. add a sort descriptor to jobs fetch request. * make job timestamp a non-optional date. add errorDescription to data store error model. correct attribute key for sortdescriptor. * inject userId and jobId from home view model into the verification product flows. * add a new case for ActionResult. * rename sortdescriptor * Fix TabBar Background (#196) * restore ipad support and disable ipad multitasking * fix tab bar background issue caused by toast view. * Fix Jobs User Id issue (#197) * use newly generated userid for authentication jobs. pass in userId and jobId into authentication request. * bump build number. * hide clear jobs button if there are no jobs * Status Progress and Scoping of Persisted Jobs (#198) * add an indeterminate linear progress view to job list item and show it when fetching job status. * add isProduction and partnerId attributes to Job model. * inject config into the JobsViewModel to gain access to partnerId * code formatting. * add a new ActionResult not previously added. hide progress view when get status task is canceled * add an unknown case to ActionResult. Display partnerId and environment on JobListeItem * add doc to newly introduced unknown case. * shorten the doc text for unknown case * Refresh Entire App when Smile Config is Updated (#199) * move smile config decoding and initialisation into root view model. add a closure to send back update config to root view. * update init method * bump build number. prevent joblistitem preview from running in release environment. * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/12793
Summary
This includes the following changes:
Known Issues
N/A
Test Instructions
Launch the demo app and you should see a new Jobs tab added to the tab view.
Screenshot