Bugfix/retrycrash #195
Merged
Bugfix/retrycrash #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 577c89e |
vanshg
approved these changes
Jul 10, 2024
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix force unwrapping files this crashes if you don't have offline enabled and the job fails and you click retry
Bonus
Example scheme wasn't debuggable so breakpoints wouldn't work
Known Issues
This leads to a loop if the user keeps clicking retry then it'll just keep failing
Test Instructions
Run a biometric kyc job with offline set to false and use an existing user id and job id, once it fails and you click retry it should't crash, currently it does and this PR fixes that
Screenshot
N/A