Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Keys Fix per Environment #207

Merged
merged 2 commits into from
Aug 5, 2024
Merged

API Keys Fix per Environment #207

merged 2 commits into from
Aug 5, 2024

Conversation

jumaallan
Copy link
Member

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

@jumaallan jumaallan requested a review from a team as a code owner July 31, 2024 14:22
Copy link

github-actions bot commented Jul 31, 2024

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/SmileID.swift#L113 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/SmileID.swift#L139 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

Generated by 🚫 Danger Swift against 0b2a698

Copy link
Contributor

@tobitech tobitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of the environment toggle based on discussions in this thread because it will now be redundant - https://smileidentity.slack.com/archives/C04G17H9JUE/p1722442289057609?thread_ts=1722437705.189679&cid=C04G17H9JUE

@jumaallan
Copy link
Member Author

I think we can get rid of the environment toggle based on discussions in this thread because it will now be redundant - https://smileidentity.slack.com/archives/C04G17H9JUE/p1722442289057609?thread_ts=1722437705.189679&cid=C04G17H9JUE

I left the toggle, so if we need to setup sandbox setup we can use the same - this is also a sample app so there is no harm really

@tobitech
Copy link
Contributor

tobitech commented Aug 1, 2024

I think we can get rid of the environment toggle based on discussions in this thread because it will now be redundant - https://smileidentity.slack.com/archives/C04G17H9JUE/p1722442289057609?thread_ts=1722437705.189679&cid=C04G17H9JUE

I left the toggle, so if we need to setup sandbox setup we can use the same - this is also a sample app so there is no harm really

Alright then.

@tobitech tobitech self-requested a review August 1, 2024 15:38
@jumaallan jumaallan merged commit 21035b8 into main Aug 5, 2024
3 checks passed
@jumaallan jumaallan deleted the fix/api-keys branch August 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants