Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/9520 #27

Merged
merged 9 commits into from
May 30, 2023
Merged

Feature/9520 #27

merged 9 commits into from
May 30, 2023

Conversation

JNdhlovu
Copy link
Contributor

Story: https://app.shortcut.com/smileid/story/9520

Summary

Use root of project to upload artifact

Known Issues

WIP need access as admin to add aws secrets

@JNdhlovu JNdhlovu requested a review from a team as a code owner May 26, 2023 15:07
@JNdhlovu JNdhlovu requested a review from JubrilO May 26, 2023 15:07
Copy link
Contributor

@JubrilO JubrilO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the CI failure, it seems there is already a directory named release. Maybe give the directory another name.

@JNdhlovu JNdhlovu requested a review from JubrilO May 29, 2023 12:05
@JNdhlovu JNdhlovu merged commit 44fc030 into main May 30, 2023
@JNdhlovu JNdhlovu deleted the feature/9520 branch May 30, 2023 08:52
@vanshg
Copy link
Contributor

vanshg commented May 30, 2023

@JNdhlovu Going forward, could you please leave a descriptive title for the PR? This makes it easier to tell at a glance the purpose of the code changes

JNdhlovu added a commit that referenced this pull request Jun 7, 2023
JNdhlovu added a commit that referenced this pull request Jun 7, 2023
JNdhlovu added a commit that referenced this pull request Jun 7, 2023
JNdhlovu added a commit that referenced this pull request Jun 7, 2023
JNdhlovu added a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants