Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename classes and targets to match new brand name SmileID #28

Merged
merged 6 commits into from
May 30, 2023
Merged

Rename classes and targets to match new brand name SmileID #28

merged 6 commits into from
May 30, 2023

Conversation

JubrilO
Copy link
Contributor

@JubrilO JubrilO commented May 26, 2023 •
edited
Loading

Summary

This PR renames all references to SmileIdentity to SmileID

Known Issues

This hasn't been tested on the CI environment yet. Should be fine if all CI checks pass.

@JubrilO JubrilO requested a review from a team as a code owner May 26, 2023 15:21
@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

Warnings
⚠️

Example/SmileIdentity/HomeViewController.swift#L66 - Line should be 120 characters or less: currently 124 characters (line_length)
⚠️

Sources/Networking/ServiceRunnable.swift#L60 - Function parameters should be aligned vertically if they're in multiple lines in a declaration. (vertical_parameter_alignment)
⚠️

Sources/SelfieCapture/View/SelfieCaptureView.swift#L18 - TODOs should be resolved (only used for previews to remo...). (todo)
⚠️

Sources/SelfieCapture/View/SmartSelfieInstructionsView.swift#L5 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️

Sources/SelfieCapture/View/SuccessView.swift#L13 - Prefer at least one space after slashes for comments. (comment_spacing)
⚠️

Sources/SelfieCapture/View/SuccessView.swift#L18 - Prefer at least one space after slashes for comments. (comment_spacing)
⚠️

Sources/SelfieCapture/View/SuccessView.swift#L19 - Prefer at least one space after slashes for comments. (comment_spacing)
⚠️

Sources/SelfieCapture/ViewModel/SelfieCaptureViewModel.swift#L23 - Type body should span 200 lines or less excluding comments and whitespace: currently spans 251 lines (type_body_length)
⚠️

Sources/SelfieCapture/ViewModel/SelfieCaptureViewModel.swift#L426 - File should contain 400 lines or less: currently contains 426 (file_length)

Generated by 🚫 Danger Swift against 61c94ab

@JubrilO JubrilO merged commit 848c39f into main May 30, 2023
@JubrilO JubrilO deleted the feature/rebrand branch May 30, 2023 12:17
vanshg
vanshg reviewed May 30, 2023
View reviewed changes
Example/SmileIdentity.xcodeproj/project.pbxproj
@@ -42,7 +42,7 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
910D2996296CDE60007FB709 /* SmileIdentity in Frameworks */,
91941A662A2103E200FFFB26 /* SmileID in Frameworks */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to rename the .xcodeproj file as well?

Example/SmileIdentity/AppDelegate.swift
@@ -1,5 +1,5 @@
import UIKit
import SmileIdentity
import SmileID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to also rename the source folder? Example/SmileID

Sources/Camera/CameraManager.swift
@@ -16,7 +16,7 @@ class CameraManager: ObservableObject {

let session = AVCaptureSession()

private let sessionQueue = DispatchQueue(label: "com.smileidentity.ios")
private let sessionQueue = DispatchQueue(label: "com.smileid.ios")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package names should remain as com.smileidentity because it is meant to be a reverse domain name notation. All our packages are still distributed under that name and smileid.com does not redirect to us

@vanshg vanshg mentioned this pull request Jun 5, 2023
Merged
JNdhlovu pushed a commit that referenced this pull request Jun 7, 2023
@JubrilO
Merge pull request #28 from smileidentity/feature/rebrand
387684b 
Rename classes and targets to match new brand name SmileID
JNdhlovu pushed a commit that referenced this pull request Jun 7, 2023
@JubrilO
Merge pull request #28 from smileidentity/feature/rebrand
e053337 
Rename classes and targets to match new brand name SmileID
JNdhlovu pushed a commit that referenced this pull request Jun 7, 2023
@JubrilO
Merge pull request #28 from smileidentity/feature/rebrand
1660628 
Rename classes and targets to match new brand name SmileID
JNdhlovu pushed a commit that referenced this pull request Jun 7, 2023
@JubrilO
Merge pull request #28 from smileidentity/feature/rebrand
b668a71 
Rename classes and targets to match new brand name SmileID
JNdhlovu pushed a commit that referenced this pull request Jan 24, 2024
@JubrilO
Merge pull request #28 from smileidentity/feature/rebrand
d435600 
Rename classes and targets to match new brand name SmileID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanshg vanshg vanshg left review comments

@JNdhlovu JNdhlovu JNdhlovu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JubrilO @vanshg @JNdhlovu