Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Capture Camera UI #45

Merged
merged 15 commits into from
Jul 20, 2023
Merged

Document Capture Camera UI #45

merged 15 commits into from
Jul 20, 2023

Conversation

JubrilO
Copy link
Contributor

@JubrilO JubrilO commented Jul 13, 2023 •
edited
Loading

Story: https://app.shortcut.com/smileid/story/9610/capture-a-good-quality-image-and-run-document-verification-with-the-new-mobile-sdk

Summary

This PR implements the UI for the document capture camera view. No image analysis is done yet

Screenshot

Screenshot 2023-07-18 at 05 01 04 Screenshot 2023-07-18 at 05 00 53

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/DocumentVerification/View/DocumentCaptureInstructionView.swift#L34 - Collection literals should not have trailing commas. (trailing_comma)
⚠️

Sources/SmileID/Classes/DocumentVerification/View/DocumentCaptureView.swift#L42 - Files should have a single trailing newline. (trailing_newline)
⚠️

Sources/SmileID/Classes/DocumentVerification/View/DocumentCaptureView.swift#L42 - Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
⚠️

Sources/SmileID/Classes/Helpers/EpilogueFont.swift#L11 - TODOs should be resolved (the project doesn't currently ...). (todo)
⚠️

Sources/SmileID/Classes/SelfieCapture/View/SmartSelfieInstructionsView.swift#L17 - Prefer _ = foo() over let _ = foo() when discarding a result from a function. (redundant_discardable_let)
⚠️

Sources/SmileID/Classes/SelfieCapture/View/SmileButton.swift#L22 - Function parameters should be aligned vertically if they're in multiple lines in a declaration. (vertical_parameter_alignment)
⚠️

Sources/SmileID/Classes/SelfieCapture/View/SmileButton.swift#L23 - Function parameters should be aligned vertically if they're in multiple lines in a declaration. (vertical_parameter_alignment)
⚠️

Sources/SmileID/Classes/Views/CaptureInstructionView.swift#L88 - Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

Generated by 🚫 Danger Swift against cdd5959

@JubrilO JubrilO marked this pull request as ready for review July 18, 2023 04:15
@JubrilO JubrilO requested a review from a team as a code owner July 18, 2023 04:15
@JubrilO JubrilO self-assigned this Jul 18, 2023
@vanshg
Copy link
Contributor

vanshg commented Jul 18, 2023

Also noticed that the buttons have different corner radii, can we make it consistent?

image

@JubrilO JubrilO requested a review from vanshg July 20, 2023 13:27
@JubrilO JubrilO changed the base branch from main to develop July 20, 2023 14:23
@JubrilO JubrilO merged commit afb9790 into develop Jul 20, 2023
3 checks passed
@JubrilO JubrilO deleted the feature/document-capture-screen branch July 20, 2023 16:37
JubrilO added a commit that referenced this pull request Aug 17, 2023
@JubrilO @vanshg @JNdhlovu
Merge develop into main (#60)
19b7c17 
* Document Capture Camera UI (#45)

* Create basic screens

* Create document capture UI

* Add instruction to the capture screen

* Update DocV icon=

* Complete document capture UI

* Fix typo

* Fix linting errors

* Fix more linting issues

* Update Sources/SmileID/Classes/DocumentVerification/View/DocumentCaptureOverlayView.swift

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

* Address PR comments

* add padding to attribution

---------

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

* Custom navstack to be used for ocherstrating screens (#40)

* Update SmileID.podspec (#54)

* Update SmileID.podspec (#55)

* fix:custom navstack for smile screens, will be used for echerstrating screen exection order

* feat:nav view

* feat:pr feedback

* fix:uiview swiftlin

* fix:smile view instruction screens and resolve conflicts

* fix:lint

* fix:lint

* fix:lint issues

* feat:new navigation

* fix:remove presentationmode

* feat:swiftlint issues

---------

Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com>

* Fix broken build CI

* Feature/services (#58)

* fix:resolve get issues

* Update Sources/SmileID/Classes/Networking/Models/Services.swift

Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com>

* fix:pr feedback

* fix:swiftlint

* fix:remove headers on get requests

* fix:comments

* swiflint issues

* fix:nav state

* Update Sources/SmileID/Classes/Networking/Models/Services.swift

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

* Update Sources/SmileID/Classes/Networking/Models/Services.swift

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

---------

Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com>
Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

---------

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>
Co-authored-by: JNdhlovu <JNdhlovu@users.noreply.github.com>
JNdhlovu added a commit that referenced this pull request Jan 24, 2024
@JubrilO @vanshg @JNdhlovu
Merge develop into main (#60)
9c25e44 
* Document Capture Camera UI (#45)

* Create basic screens

* Create document capture UI

* Add instruction to the capture screen

* Update DocV icon=

* Complete document capture UI

* Fix typo

* Fix linting errors

* Fix more linting issues

* Update Sources/SmileID/Classes/DocumentVerification/View/DocumentCaptureOverlayView.swift

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

* Address PR comments

* add padding to attribution

---------

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

* Custom navstack to be used for ocherstrating screens (#40)

* Update SmileID.podspec (#54)

* Update SmileID.podspec (#55)

* fix:custom navstack for smile screens, will be used for echerstrating screen exection order

* feat:nav view

* feat:pr feedback

* fix:uiview swiftlin

* fix:smile view instruction screens and resolve conflicts

* fix:lint

* fix:lint

* fix:lint issues

* feat:new navigation

* fix:remove presentationmode

* feat:swiftlint issues

---------

Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com>

* Fix broken build CI

* Feature/services (#58)

* fix:resolve get issues

* Update Sources/SmileID/Classes/Networking/Models/Services.swift

Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com>

* fix:pr feedback

* fix:swiftlint

* fix:remove headers on get requests

* fix:comments

* swiflint issues

* fix:nav state

* Update Sources/SmileID/Classes/Networking/Models/Services.swift

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

* Update Sources/SmileID/Classes/Networking/Models/Services.swift

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

---------

Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com>
Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>

---------

Co-authored-by: Vansh Gandhi <vansh@smileidentity.com>
Co-authored-by: JNdhlovu <JNdhlovu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanshg vanshg vanshg approved these changes

Assignees

@JubrilO JubrilO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JubrilO @vanshg