Allow leaving id_number and id_type fields empty in id_info for JT6. #60
Conversation
lib/smile-identity-core/web_api.rb
Outdated
| @@ -93,6 +93,7 @@ def id_info=(id_info) | |||
|
|
|||
| if updated_id_info[:entered] && updated_id_info[:entered] == 'true' | |||
| %i[country id_type id_number].each do |key| | |||
| next if @partner_params[:job_type].to_i == JobType::DOCUMENT_VERIFICATION | |||
There was a problem hiding this comment.
Do we want to do this for all fields or just id_type? Why not do this above the loop rather than inside of it?
There was a problem hiding this comment.
Yeah makes sense 👍
lib/smile-identity-core/web_api.rb
Outdated
| @@ -91,7 +91,7 @@ def id_info=(id_info) | |||
| # if it's a boolean | |||
| updated_id_info[:entered] = id_info[:entered].to_s if !updated_id_info[:entered].nil? == updated_id_info[:entered] | |||
|
|
|||
| if updated_id_info[:entered] && updated_id_info[:entered] == 'true' | |||
| if updated_id_info[:entered] && updated_id_info[:entered] == 'true' && @partner_params[:job_type].to_i != JobType::DOCUMENT_VERIFICATION | |||
There was a problem hiding this comment.
You should check for equality instead. != JobType::DOCUMENT_VERIFICATION will be more fragile than checking against known job types. [country id_type id_number] are required for JobType::BIOMETRIC_KYC, JobType::DOCUMENT_VERIFICATION needs [country]
There was a problem hiding this comment.
I'm not sure i get the equality part. I'm not checking the type here. JobType::DOCUMENT_VERIFICATION resolves to 6. See https://github.com/smileidentity/smile-identity-core-ruby/blob/main/lib/smile-identity-core/constants/job_type.rb#L17
Co-authored-by: Michael <michael.l.dangelo@gmail.com>
nii-mants3
changed the title
There was a problem hiding this comment.
This looks good to me. Going to defer to @beaglebets for final approval. Thank you @nii-mants3
lib/smile-identity-core/web_api.rb
Outdated
| @@ -91,8 +91,13 @@ def id_info=(id_info) | |||
| # if it's a boolean | |||
| updated_id_info[:entered] = id_info[:entered].to_s if !updated_id_info[:entered].nil? == updated_id_info[:entered] | |||
|
|
|||
| if updated_id_info[:entered] && updated_id_info[:entered] == 'true' | |||
| %i[country id_type id_number].each do |key| | |||
| if updated_id_info[:entered] == 'true' | |||
There was a problem hiding this comment.
I don't think this condition (entered == 'true') is necessary for job type 6, but I'll defer to @beaglebets. If it's not necessary, consider moving the JobType::DOCUMENT_VERIFICATION check above entered.
This PR introduces changes to allow
countryandid_typefields to be empty inid_infofor JT6