Glyco Visualization Crash Fix on ambiguous protein from peptide #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a crash in the sequence annotation
nbollis
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2317 +/- ##
=======================================
Coverage 92.67% 92.67%
=======================================
Files 135 135
Lines 20982 20987 +5
Branches 2880 2880
=======================================
+ Hits 19445 19450 +5
Misses 1063 1063
Partials 474 474
|
nbollis
requested review from
trishorts,
Alexander-Sol,
YulingDai,
elaboy and
kyp4
elaboy
approved these changes
Nov 21, 2023
trishorts
approved these changes
Nov 28, 2023
Alexander-Sol
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the PsmFromTsv.StartAndEndResidueInProtein was set to "".
This caused the DrawnSequence.AnnotateBaseSequence to crash.
A simple if statement was enough to circumvent this issue and allow plotting.
This issue is caused by the peptide sequence not being unique and could potentially derive from several proteins.