Eliminate delta score option #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2338 +/- ##
==========================================
- Coverage 92.67% 92.63% -0.05%
==========================================
Files 136 136
Lines 21321 21302 -19
Branches 2930 2924 -6
==========================================
- Hits 19760 19733 -27
- Misses 1081 1095 +14
+ Partials 480 474 -6
|
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
nbollis,
zhuoxinshi and
RayMSMS
nbollis
approved these changes
Feb 2, 2024
YulingDai
approved these changes
Feb 2, 2024
elaboy
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a relatively unknown scoring option in MetaMorpheus that was created by one of our grad students some number of years ago. I don't believe that it is really ever used and it is causing me some headaches in the computation of q-value.
This PR eliminates that feature.