Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 -Spectral Match Generalization #2340

Merged
merged 34 commits into from
Mar 6, 2024

Conversation

nbollis
Copy link
Contributor

@nbollis nbollis commented Feb 9, 2024

Generalized the PeptideSpectralMatch class to a generic SpectralMatch class. This enables OligoSpectralMatch to use all of the same Writing classes and a vast majority of the FDR calculations.
Also added some tests to the Bin class for test coverage

@nbollis nbollis changed the title #3 - [Waiting on Omics][Waiting On Decon Generalization] Spectral Match Generalization #3 - [Waiting On Decon Generalization] Spectral Match Generalization Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 92.72503% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 92.67%. Comparing base (8ab02bc) to head (11c8e82).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2340      +/-   ##
==========================================
+ Coverage   92.65%   92.67%   +0.02%     
==========================================
  Files         136      137       +1     
  Lines       21243    21259      +16     
  Branches     2930     2939       +9     
==========================================
+ Hits        19682    19702      +20     
+ Misses       1083     1077       -6     
- Partials      478      480       +2     
Files Coverage Δ
...ineLayer/Calibration/DataPointAquisitionResults.cs 80.43% <100.00%> (ø)
...rpheus/EngineLayer/Calibration/LabeledDataPoint.cs 100.00% <100.00%> (ø)
...s/EngineLayer/ClassicSearch/ClassicSearchEngine.cs 97.84% <100.00%> (ø)
...gineLayer/CrosslinkSearch/CrosslinkSearchEngine.cs 91.08% <100.00%> (ø)
...EngineLayer/CrosslinkSearch/CrosslinkedPeptides.cs 100.00% <100.00%> (ø)
...aMorpheus/EngineLayer/GlycoSearch/GlycoPeptides.cs 88.03% <100.00%> (ø)
...pheus/EngineLayer/GlycoSearch/GlycoSearchEngine.cs 92.67% <100.00%> (ø)
MetaMorpheus/EngineLayer/Gptmd/GptmdEngine.cs 89.34% <100.00%> (ø)
...eus/EngineLayer/Localization/LocalizationEngine.cs 98.36% <100.00%> (ø)
...eus/EngineLayer/ModernSearch/ModernSearchEngine.cs 74.54% <100.00%> (ø)
... and 35 more

@trishorts
Copy link
Contributor

wonder about switching from psm to sm for all things. would be a big change.

@nbollis nbollis changed the title #3 - [Waiting On Decon Generalization] Spectral Match Generalization #3 -Spectral Match Generalization Feb 27, 2024
@trishorts trishorts merged commit d136417 into smith-chem-wisc:master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants