Eliminate PsmCount from PEP calculation #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2347 +/- ##
==========================================
+ Coverage 92.65% 92.74% +0.08%
==========================================
Files 136 137 +1
Lines 21243 21199 -44
Branches 2930 2932 +2
==========================================
- Hits 19682 19660 -22
+ Misses 1083 1056 -27
- Partials 478 483 +5
|
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
kyp4,
nbollis,
zhuoxinshi and
RayMSMS
nbollis
reviewed
Feb 20, 2024
| @@ -95,20 +94,6 @@ internal static (string ResolvedString, Dictionary<string, int> ResolvedValue) R | |||
| } | |||
| } | |||
|
|
|||
| internal static (string ResolvedString, double? ResolvedValue) ResolveF2(IEnumerable<double> enumerable) | |||
There was a problem hiding this comment.
no longer needed.
| @@ -189,6 +195,14 @@ public void SetFdrValues(double cumulativeTarget, double cumulativeDecoy, double | |||
| }; | |||
| } | |||
|
|
|||
| public void SetQandPEPvalues(double qValue, double qValueNotch, double pep, double pepQValue) | |||
There was a problem hiding this comment.
Will the other fields in FdrInfo need to be updated as well?
There was a problem hiding this comment.
see comment in revised PR
nbollis
approved these changes
Feb 22, 2024
… into updatePepX2
Alexander-Sol
approved these changes
Mar 5, 2024
elaboy
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuz some smart people think that introduces bias.
https://pubmed.ncbi.nlm.nih.gov/21391616/