Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaDraw Fragmentation Reanalysis #2361

Merged
merged 22 commits into from
Jun 19, 2024

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Apr 29, 2024

Enables the reanalysis of a fragmentation spectrum with additional fragment ion types.

The plotting methods use the MatchedIons of the psm that gets passed in to determine what to plot. To enable this functionality, I had to temporarily replace the fragment ions in the psm with the new matched ions, then put the original ions back in once the plotting has finished.

To use: have your normal MetaDraw Display
image

Select the additional ions you want to search for
image

His the search button. The persist check box will enable this research on all new PSMs you plot

image

…nctional code of the new controls finished, just need to integtrate with the existing MetaDraw structure
…to open up the set methods for the fragment ions in each PsmFromTsv
@nbollis nbollis added the WIP Work in progress, not ready for review label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 97.48744% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.89%. Comparing base (efa9b9d) to head (c9a5d79).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2361      +/-   ##
==========================================
+ Coverage   92.85%   92.89%   +0.04%     
==========================================
  Files         137      139       +2     
  Lines       21242    21435     +193     
  Branches     2931     2944      +13     
==========================================
+ Hits        19725    19913     +188     
- Misses       1040     1043       +3     
- Partials      477      479       +2     
Files Coverage Δ
MetaMorpheus/EngineLayer/PsmTsv/PsmFromTsv.cs 97.69% <100.00%> (ø)
...etaMorpheus/GuiFunctions/MetaDraw/DrawnSequence.cs 99.36% <100.00%> (ø)
.../MetaDraw/FragmentResearching/FragmentViewModel.cs 100.00% <100.00%> (ø)
...Morpheus/GuiFunctions/MetaDraw/MetaDrawSettings.cs 99.37% <100.00%> (+0.21%) ⬆️
...etaMorpheus/GuiFunctions/MetaDraw/MetaDrawLogic.cs 95.63% <80.00%> (-0.11%) ⬇️
...entResearching/FragmentationReanalysisViewModel.cs 95.91% <95.91%> (ø)

@trishorts
Copy link
Contributor

pretty cool. i only ever see yAmmoniaLoss. maybe we need unit tests for each of the ion types? sounds like lots of work...... I wonder if we paste a couple of example spectra into proteinprospector if it sees any other fragments.

@nbollis
Copy link
Member Author

nbollis commented May 3, 2024

That is a good idea and maybe a good starter project. Our current tests only truly test b, y, and c ions

@nbollis nbollis added ready for review and removed WIP Work in progress, not ready for review labels May 9, 2024
Copy link
Contributor

@Alexander-Sol Alexander-Sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it and it worked great

@trishorts
Copy link
Contributor

is the top supposed to look like this?
image

@trishorts
Copy link
Contributor

i think that export spectrum library should maybe contain the newly annotated fragments.
image

@nbollis
Copy link
Member Author

nbollis commented Jun 17, 2024

is the top supposed to look like this? image

This has been fixed

@trishorts trishorts merged commit 9b3118c into smith-chem-wisc:master Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants