-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetaDraw Fragmentation Reanalysis #2361
MetaDraw Fragmentation Reanalysis #2361
Conversation
…nctional code of the new controls finished, just need to integtrate with the existing MetaDraw structure
…to open up the set methods for the fragment ions in each PsmFromTsv
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
==========================================
+ Coverage 92.85% 92.89% +0.04%
==========================================
Files 137 139 +2
Lines 21242 21435 +193
Branches 2931 2944 +13
==========================================
+ Hits 19725 19913 +188
- Misses 1040 1043 +3
- Partials 477 479 +2
|
pretty cool. i only ever see yAmmoniaLoss. maybe we need unit tests for each of the ion types? sounds like lots of work...... I wonder if we paste a couple of example spectra into proteinprospector if it sees any other fragments. |
That is a good idea and maybe a good starter project. Our current tests only truly test b, y, and c ions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled it and it worked great
Enables the reanalysis of a fragmentation spectrum with additional fragment ion types.
The plotting methods use the MatchedIons of the psm that gets passed in to determine what to plot. To enable this functionality, I had to temporarily replace the fragment ions in the psm with the new matched ions, then put the original ions back in once the plotting has finished.
To use: have your normal MetaDraw Display
Select the additional ions you want to search for
His the search button. The persist check box will enable this research on all new PSMs you plot