Stop scrolling of progress bar after calculating spectral angle #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2372 +/- ##
=======================================
Coverage 92.81% 92.81%
=======================================
Files 137 137
Lines 21170 21171 +1
Branches 2924 2924
=======================================
+ Hits 19649 19650 +1
Misses 1042 1042
Partials 479 479
|
nbollis
requested review from
trishorts,
Alexander-Sol,
YulingDai,
zhuoxinshi and
RayMSMS
Alexander-Sol
approved these changes
Jun 13, 2024
avcarr2
approved these changes
Jun 13, 2024
YulingDai
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After calculating the spectral angle during a search task, the progress bar would scroll infinitely.
This simple PR stops the scrolling after angle calculation is complete.