Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pep on peptides first #2373

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Conversation

trishorts
Copy link
Contributor

@trishorts trishorts commented Jun 12, 2024

We have been training our binary decision tree on psms rather than peptides. PSMs for the same peptide are not independent measurements. Therefore, they are not a good choice for ML training applications. This PR uses peptides instead and then applies that model to the PSMs.

Also, there are some efficiency and orangizational improvements.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 95.16129% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.85%. Comparing base (a025ca0) to head (a1095fd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2373      +/-   ##
==========================================
+ Coverage   92.81%   92.85%   +0.04%     
==========================================
  Files         137      137              
  Lines       21188    21242      +54     
  Branches     2929     2931       +2     
==========================================
+ Hits        19666    19725      +59     
+ Misses       1042     1040       -2     
+ Partials      480      477       -3     
Files Coverage Δ
...pheus/EngineLayer/FdrAnalysis/FdrAnalysisEngine.cs 96.52% <100.00%> (+0.02%) ⬆️
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 93.26% <100.00%> (ø)
...EngineLayer/FdrAnalysis/PEPValueAnalysisGeneric.cs 95.71% <93.54%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

@nbollis nbollis merged commit efa9b9d into smith-chem-wisc:master Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants