-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pep on peptides first #2373
Merged
Merged
Pep on peptides first #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2373 +/- ##
==========================================
+ Coverage 92.81% 92.85% +0.04%
==========================================
Files 137 137
Lines 21188 21242 +54
Branches 2929 2931 +2
==========================================
+ Hits 19666 19725 +59
+ Misses 1042 1040 -2
+ Partials 480 477 -3
|
avcarr2
approved these changes
Jun 13, 2024
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
nbollis,
zhuoxinshi and
RayMSMS
June 14, 2024 16:52
Alexander-Sol
approved these changes
Jun 18, 2024
zhuoxinshi
approved these changes
Jun 18, 2024
nbollis
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been training our binary decision tree on psms rather than peptides. PSMs for the same peptide are not independent measurements. Therefore, they are not a good choice for ML training applications. This PR uses peptides instead and then applies that model to the PSMs.
Also, there are some efficiency and orangizational improvements.