Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous file loading for search task #2381

Merged
merged 17 commits into from
Jul 3, 2024

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Jun 26, 2024

Changed the loading of MsDataFiles, Proteins, Spectral Libraries, and Modifications to asynchronous methods within search task.

This enables a file to loading in the background and the main thread to continue execution.
Wait handlers were added to ensure the files are loaded before they are needed by the rest of the code.

The main meat of this PR is that we are now loading the next MsDataFile to be searched, while the previous one is being searched.

MM 1.0.5 and this PR were ran side by side for a
47 raw file top down search:

  • 1.0.5 time -> 1:20:56
  • This PR time -> 1:01:47

20 mzml file top down search:

  • 1.0.5 time -> 3:40:56
  • This PR time -> 2:59:23

@nbollis nbollis added Maintenance WIP Work in progress, not ready for review labels Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (93b672e) to head (9620228).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2381   +/-   ##
=======================================
  Coverage   92.89%   92.90%           
=======================================
  Files         139      139           
  Lines       21435    21461   +26     
  Branches     2944     2948    +4     
=======================================
+ Hits        19913    19939   +26     
  Misses       1043     1043           
  Partials      479      479           
Files Coverage Δ
MetaMorpheus/TaskLayer/SearchTask/SearchTask.cs 95.83% <100.00%> (+0.28%) ⬆️

@nbollis nbollis added ready for review and removed WIP Work in progress, not ready for review labels Jun 27, 2024
Copy link
Contributor

@elaboy elaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great optimization Nic

@trishorts trishorts merged commit 458e4d2 into smith-chem-wisc:master Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants