-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to PEP Calculation and Filtering #2387
Merged
trishorts
merged 56 commits into
smith-chem-wisc:master
from
Alexander-Sol:ShortreedPep3
Aug 5, 2024
Merged
Changes to PEP Calculation and Filtering #2387
trishorts
merged 56 commits into
smith-chem-wisc:master
from
Alexander-Sol:ShortreedPep3
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the results from a search @trishorts ran using an arabidopsis entrapment database |
Alexander-Sol
force-pushed
the
ShortreedPep3
branch
from
July 29, 2024 23:42
0794c1a
to
95b3135
Compare
trishorts
approved these changes
Jul 30, 2024
nbollis
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments and questions
MetaMorpheus/EngineLayer/ProteinParsimony/ProteinParsimonyEngine.cs
Outdated
Show resolved
Hide resolved
trishorts
approved these changes
Aug 2, 2024
trishorts
approved these changes
Aug 2, 2024
nbollis
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10/10
nbollis
approved these changes
Aug 5, 2024
zhuoxinshi
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been several iterations of this guy, but all the tests are finally passing. See also PR 2376