Increased QValue cutoff for calibrating PSMs to 0.01 #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Sol
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 139 139
Lines 21720 21725 +5
Branches 3004 3003 -1
=======================================
+ Hits 20351 20356 +5
Misses 910 910
Partials 459 459
|
nbollis
approved these changes
Aug 2, 2024
trishorts
approved these changes
Aug 2, 2024
zhuoxinshi
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the way Q-Value is calculate have increased Q-Values across the board.
This caused calibration to fail on files that MetaMorpheus used to calibrate successfully.
To address this, I increased the Q-value Notch cut-off for PSMs that are used for calibration from 0.001 to 0.01. I also created a property within CalibrationParameters that reflects this cutoff threshold. Previously it was just a magic number buried in CalibrationTask.