Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result Text and Individual File Result Cleanup #2397

Merged
merged 20 commits into from
Aug 16, 2024

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Aug 6, 2024

Some issues were created in the most recent PostSeachAnalysisTask refactoring.

Result Writing Adjustments

  • Adjusted peptide/proteoform results to use the correct label when outputting.
  • Moved the creation of individual file results directory from the WriteProteinGroups method to main method in PostSearchAnalysisTask
  • Adjusted the output to say <= 0.01 instead of = 0.01 for all result.txt summary lines.

Additional Tests

  • Added test to ensure that the Result.txt has the correct result types (peptide/proteoform) and correct number of consensus/individual file result summary lines.
  • Added test to ensure that the correct number individual file result files were written out and had the correct name.

Test Refactoring

  • Combined both SetUpFixtures within the Test Project.
  • Adjusted the PostSearchAnalysisTaskTest to pull their search data from a test case to reduce redundant searches.
  • Each test case will only be searched one time and the results can be pulled from the respective output directory.
  • The test cases are disposed (directory containing results deleted) at the very end of all test running as found in the SetupTest.GlobalTearDown method.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.65%. Comparing base (401a5a9) to head (49a18dc).
Report is 1 commits behind head on master.

Files Patch % Lines
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 92.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
+ Coverage   93.62%   93.65%   +0.02%     
==========================================
  Files         140      140              
  Lines       21895    21896       +1     
  Branches     3005     3005              
==========================================
+ Hits        20499    20506       +7     
+ Misses        937      934       -3     
+ Partials      459      456       -3     
Files Coverage Δ
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 93.97% <92.00%> (+0.33%) ⬆️

... and 1 file with indirect coverage changes

@nbollis nbollis merged commit 1d402e2 into smith-chem-wisc:master Aug 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants