Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions 1: Cross Platform Build #2398

Merged
merged 30 commits into from
Aug 23, 2024
Merged

Github Actions 1: Cross Platform Build #2398

merged 30 commits into from
Aug 23, 2024

Conversation

nbollis
Copy link
Contributor

@nbollis nbollis commented Aug 16, 2024

Created a github action that builds MetaMorpheus on Windows, Linux, and mac.

To build on windows and mac, a new configuration was generated that excluded the MetaMorphesusSetup and Project.wix Projects

@nbollis nbollis changed the title Create build.yml Github Actions: Cross Platform Build Aug 16, 2024
@nbollis nbollis changed the title Github Actions: Cross Platform Build Github Actions 1: Cross Platform Build Aug 16, 2024
@nbollis nbollis marked this pull request as ready for review August 16, 2024 21:27
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (22c8fe0) to head (cb03621).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2398   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         140      140           
  Lines       21896    21896           
  Branches     3005     3005           
=======================================
  Hits        20506    20506           
  Misses        934      934           
  Partials      456      456           

MetaMorpheus/GUI/GUI.csproj Outdated Show resolved Hide resolved
MetaMorpheus/MetaMorpheusSetup/MetaMorpheusSetup.wixproj Outdated Show resolved Hide resolved
@@ -377,7 +379,7 @@ public static void SpectralWriterTest()
postSearchTask.Run();

var libraryList = Directory.GetFiles(path, "*.*", SearchOption.AllDirectories);
string updateLibraryPath = libraryList.First(p => p.Contains("SpectralLibrary") && !p.Contains(matchingvalue)).ToString();
string updateLibraryPath = libraryList.First(p => p.Contains("updateSpectralLibrary") && !p.Contains(matchingvalue)).ToString();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@trishorts trishorts merged commit c0bb0a0 into master Aug 23, 2024
6 checks passed
@acesnik
Copy link
Contributor

acesnik commented Aug 23, 2024

Related issue for reference, #2088

@acesnik acesnik deleted the nbollis-patch-1 branch August 23, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants