Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PEP to use set seed (42) #2408

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Conversation

Alexander-Sol
Copy link
Contributor

@Alexander-Sol Alexander-Sol commented Sep 4, 2024

PEP was causing variability in the number of psms/proteoforms/peptides reported at 1% Q-Value and PEP Q-Value thresholds. This issue was ultimately caused by a random component in the generation of decoys. That issue is resolved in the newest version of mzLib (1.0.552)

Changes

  • Update to mzLib 1.0.552
  • Added FastTreeOptions property to the top of the PepAnalysisEngine, which contains seeds and hyperparameters for the BGDT classifier

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (dd5e3b2) to head (329d9e8).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2408   +/-   ##
=======================================
  Coverage   93.64%   93.65%           
=======================================
  Files         141      141           
  Lines       21884    21903   +19     
  Branches     3004     3004           
=======================================
+ Hits        20494    20513   +19     
  Misses        938      938           
  Partials      452      452           
Files with missing lines Coverage Δ
MetaMorpheus/EngineLayer/FdrAnalysis/FdrInfo.cs 100.00% <100.00%> (ø)
...pheus/EngineLayer/FdrAnalysis/PEPAnalysisEngine.cs 95.04% <100.00%> (+0.08%) ⬆️
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 93.97% <100.00%> (ø)

@nbollis nbollis merged commit 4d5e0ef into smith-chem-wisc:master Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants