-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PEP to use set seed (42) #2408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2408 +/- ##
=======================================
Coverage 93.64% 93.65%
=======================================
Files 141 141
Lines 21884 21903 +19
Branches 3004 3004
=======================================
+ Hits 20494 20513 +19
Misses 938 938
Partials 452 452
|
trishorts
approved these changes
Sep 11, 2024
Alexander-Sol
force-pushed
the
PepSeed
branch
from
September 13, 2024 20:38
7c45323
to
2665cfb
Compare
nbollis
approved these changes
Sep 13, 2024
zhuoxinshi
approved these changes
Sep 13, 2024
elaboy
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP was causing variability in the number of psms/proteoforms/peptides reported at 1% Q-Value and PEP Q-Value thresholds. This issue was ultimately caused by a random component in the generation of decoys. That issue is resolved in the newest version of mzLib (1.0.552)
Changes