Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encyclopedia formated peptide full sequence including mass shift in brackets #726

Conversation

trishorts
Copy link
Contributor

some external tools require that peptide sequence is formatted with mass shifts rather than PTM names for operation.
This PR adds a new method to peptidesWithSetModifications that yields the required output.

MICHAEL SHORTREED and others added 30 commits November 18, 2021 12:30
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #726 (b62ce79) into master (40dc604) will increase coverage by 0.13%.
The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   75.95%   76.09%   +0.13%     
==========================================
  Files         170      170              
  Lines       28801    28836      +35     
==========================================
+ Hits        21876    21942      +66     
+ Misses       6925     6894      -31     
Files Changed Coverage Δ
...roteolyticDigestion/PeptideWithSetModifications.cs 97.32% <91.42%> (+3.15%) ⬆️

Copy link
Contributor

@kyp4 kyp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passes tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment regarding what this tests

@trishorts trishorts merged commit 693fcb0 into smith-chem-wisc:master Sep 13, 2023
1 check passed
trishorts added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants