-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semi colon in protein group explanation #728
Merged
trishorts
merged 32 commits into
smith-chem-wisc:master
from
trishorts:semiColonInProteinGroupExplanation
Aug 28, 2023
Merged
Semi colon in protein group explanation #728
trishorts
merged 32 commits into
smith-chem-wisc:master
from
trishorts:semiColonInProteinGroupExplanation
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishorts
requested review from
Alexander-Sol,
YulingDai,
avcarr2,
kyp4 and
nbollis
August 28, 2023 18:50
elaboy
approved these changes
Aug 28, 2023
acesnik
approved these changes
Aug 28, 2023
nbollis
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explains the appearance of the semi-colon in a protein group accession for the chromatographic peak.
Occasionally one sees a semi-colon in the protein accession column of allQuantifiedPeptides in MetaMorpheus. Here are some examples.
During protein parsimony, you can get situations where all peptides are shared between two or more proteins. In other words, there is no unique peptide that could resolve the parsimony. In this case you would see something like P00001 | P00002.
That’s the easy part and you already understand that.
Now imagine another scenario where you have some other peptides (that are not in either P00001 or P00002) that give you a second group, like the one above. Let’s call it P00003 | P00004. Everything is still fine her.
Now you have two protein groups each with two proteins.
Here is where the semi-colon comes in.
Imagine you now find a new peptide (totally different from any of the peptides used to create the two original protein groups) that is shared across all four proteins. The original peptides require that two different protein groups exist, but this new peptide could come from either or both. We don’t know. So, the quantification of that peptide must be allowed to be to either/both groups. For this peptide, the protein accession in the output will be P00001|P00002;P00003|P00004.
You could see an output that looks like P0000A;P0000B. Here there is only one protein in each protein group (as decided by parsimony). And you have a peptide that is shared. This would not ever be reported as P0000A|P0000B because each protein has a unique peptide that confirms its existence.