-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved intensity pairs trying to make spectrum library comparisons faster #765
Merged
Alexander-Sol
merged 47 commits into
smith-chem-wisc:master
from
trishorts:improvedIntensityPairs
Apr 18, 2024
Merged
Improved intensity pairs trying to make spectrum library comparisons faster #765
Alexander-Sol
merged 47 commits into
smith-chem-wisc:master
from
trishorts:improvedIntensityPairs
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishorts
changed the title
Improved intensity pairs trying to make SLS faster
Improved intensity pairs trying to make spectrum library comparisons faster
Feb 28, 2024
nbollis
reviewed
Mar 1, 2024
nbollis
approved these changes
Mar 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 75.06% 75.04% -0.02%
==========================================
Files 189 189
Lines 30235 30236 +1
Branches 3035 3034 -1
==========================================
- Hits 22697 22692 -5
- Misses 7024 7029 +5
- Partials 514 515 +1
|
YulingDai
approved these changes
Mar 3, 2024
elaboy
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is to make the computation of spectrum similarity a little faster.
Overall, I attempted also to improve the code.
Some points to clarify because some changes were made: