Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet.yml #767

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Update dotnet.yml #767

merged 3 commits into from
Mar 1, 2024

Conversation

Alexander-Sol
Copy link
Contributor

@Alexander-Sol Alexander-Sol commented Feb 29, 2024

The coverlet nuget package, which we use for analyzing code coverage, released an update about a week ago. The updated version is broken.

This PR uses the previous version of coverlet, v6.0.0, to avoid the problem that was introduced in v6.0.1

Added coverlet dependency "System.Text.Json" to the github actions workflow
Rollback coverlet to previous version
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.06%. Comparing base (4790e3e) to head (2c0254e).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   75.05%   75.06%   +0.01%     
==========================================
  Files         189      189              
  Lines       30235    30235              
  Branches     3035     3035              
==========================================
+ Hits        22693    22697       +4     
+ Misses       7028     7024       -4     
  Partials      514      514              

see 1 file with indirect coverage changes

@Alexander-Sol Alexander-Sol added Maintenance The user isn't impacted by it, it's purely behind the scenes ready for final review / merge labels Feb 29, 2024
@trishorts trishorts merged commit cf854ac into master Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance The user isn't impacted by it, it's purely behind the scenes ready for final review / merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants