Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for crux output #774

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Apr 11, 2024

Added support for reading and writing a .txt output from crux and Shortreed's request.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.30%. Comparing base (9917d58) to head (7edcfd9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   75.27%   75.30%   +0.03%     
==========================================
  Files         195      197       +2     
  Lines       30482    30541      +59     
  Branches     3058     3063       +5     
==========================================
+ Hits        22944    22999      +55     
- Misses       7024     7026       +2     
- Partials      514      516       +2     
Files Coverage Δ
mzLib/MzLibUtil/ClassExtensions.cs 100.00% <100.00%> (ø)
...ernalResults/IndividualResultRecords/CruxResult.cs 100.00% <100.00%> (ø)
...ders/ExternalResults/ResultFiles/CruxResultFile.cs 90.47% <90.47%> (ø)
mzLib/Readers/Util/SupportedFileTypes.cs 97.05% <50.00%> (-2.95%) ⬇️

trishorts
trishorts previously approved these changes Apr 17, 2024
Alexander-Sol
Alexander-Sol previously approved these changes Apr 18, 2024
@nbollis nbollis dismissed stale reviews from Alexander-Sol and trishorts via 3740cf2 April 23, 2024 17:32
@nbollis nbollis merged commit 182115c into smith-chem-wisc:master Jul 11, 2024
3 checks passed
elaboy added a commit to elaboy/mzLib-Fork that referenced this pull request Aug 5, 2024
* Added support for crux output

* cleaned up code and added one test

* reverted change to period tolerant file name without extension

---------

Co-authored-by: Edwin Laboy <63374885+elaboy@users.noreply.github.com>
Co-authored-by: trishorts <mshort@chem.wisc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants