-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for crux output #774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #774 +/- ##
==========================================
+ Coverage 75.27% 75.30% +0.03%
==========================================
Files 195 197 +2
Lines 30482 30541 +59
Branches 3058 3063 +5
==========================================
+ Hits 22944 22999 +55
- Misses 7024 7026 +2
- Partials 514 516 +2
|
trishorts
requested review from
trishorts,
Alexander-Sol,
YulingDai,
elaboy,
zhuoxinshi and
RayMSMS
April 17, 2024 15:25
trishorts
previously approved these changes
Apr 17, 2024
Alexander-Sol
previously approved these changes
Apr 18, 2024
trishorts
approved these changes
Apr 24, 2024
Alexander-Sol
approved these changes
May 7, 2024
elaboy
approved these changes
Jun 3, 2024
elaboy
added a commit
to elaboy/mzLib-Fork
that referenced
this pull request
Aug 5, 2024
* Added support for crux output * cleaned up code and added one test * reverted change to period tolerant file name without extension --------- Co-authored-by: Edwin Laboy <63374885+elaboy@users.noreply.github.com> Co-authored-by: trishorts <mshort@chem.wisc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for reading and writing a .txt output from crux and Shortreed's request.