Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFragger Results Folder Reader #792

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

mzhastings
Copy link
Contributor

@mzhastings mzhastings commented Aug 19, 2024

Implemented method to more efficiently access MsFragger results using the full results folder rather than accessing each psm.tsv file within the folder individually.

Main

  • MsFraggerCombinedResults uses the path to the folder generated by MsFragger to collectively access the results from every psm.tsv file in the folder and concatenate them into one complete list of results.

Result Files

  • ExperimentAnnotation and ExperimentAnnotationFile enable reading of the expriment_annotation.tsv file produced in the MsFragger results folder. This file contains the file path to each raw result file and their corresponding sample names, which are both necessary for locating the psm.tsv files.

mzhastings and others added 25 commits July 29, 2024 13:48
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (983c3b0) to head (49a5149).

Files with missing lines Patch % Lines
...nalResults/ResultFiles/MsFraggerCombinedResults.cs 92.30% 4 Missing and 2 partials ⚠️
...nalResults/ResultFiles/ExperimentAnnotationFile.cs 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
+ Coverage   75.52%   75.59%   +0.06%     
==========================================
  Files         202      205       +3     
  Lines       30945    31057     +112     
  Branches     3129     3142      +13     
==========================================
+ Hits        23371    23477     +106     
- Misses       7040     7044       +4     
- Partials      534      536       +2     
Files with missing lines Coverage Δ
...ts/IndividualResultRecords/ExperimentAnnotation.cs 100.00% <100.00%> (ø)
...rs/ExternalResults/ResultFiles/MsFraggerPsmFile.cs 100.00% <ø> (+5.26%) ⬆️
mzLib/Readers/Util/SupportedFileTypes.cs 97.59% <100.00%> (+0.09%) ⬆️
...nalResults/ResultFiles/ExperimentAnnotationFile.cs 89.47% <89.47%> (ø)
...nalResults/ResultFiles/MsFraggerCombinedResults.cs 92.30% <92.30%> (ø)

@mzhastings mzhastings changed the title [WIP] Added interfaces for Quant and MsFragger result files Added interfaces for Quant and MsFragger result files Sep 6, 2024
@mzhastings mzhastings changed the title Added interfaces for Quant and MsFragger result files MSFragger Results Folder Reader Sep 6, 2024
Copy link
Contributor

@nbollis nbollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Working with all the fragger individual files is very annoying, this will be a lovely addition to our ever-growing collection of readers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants