Modified decoy scrambler to no longer use static Random generator #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
=======================================
Coverage 75.52% 75.52%
=======================================
Files 202 202
Lines 30945 30945
Branches 3129 3129
=======================================
Hits 23371 23371
Misses 7040 7040
Partials 534 534
|
trishorts
approved these changes
Sep 13, 2024
elaboy
approved these changes
Sep 13, 2024
zhuoxinshi
approved these changes
Sep 13, 2024
nbollis
approved these changes
Sep 13, 2024
RayMSMS
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the decoy scramble methods, previously a static Random object was used to generate scrambled sequences. This gave non-reproducible results. The method has been changed to initialize a new Random object each time the method is called.