-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Omics to read additional SpectrumMatchFromTsv types #807
Draft
nbollis
wants to merge
12
commits into
smith-chem-wisc:master
Choose a base branch
from
nbollis:TranscriptomicsUpdate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbollis
added
Maintenance
The user isn't impacted by it, it's purely behind the scenes
WIP
labels
Oct 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
==========================================
- Coverage 76.48% 76.46% -0.03%
==========================================
Files 211 212 +1
Lines 31960 32080 +120
Branches 3286 3298 +12
==========================================
+ Hits 24446 24531 +85
- Misses 6954 6984 +30
- Partials 560 565 +5
|
Corrected the mapping of `NextResidue` and `PreviousResidue` headers in the `parsedHeader` dictionary. The headers are now correctly mapped to `SpectrumMatchFromTsvHeader.NextResidue` and `SpectrumMatchFromTsvHeader.PreviousResidue` in both conditional branches.
nbollis
changed the title
Update Omics to reflect upcoming changes in MetaMorpheus
Update Omics to read additional SpectrumMatchFromTsv types
Oct 29, 2024
trishorts
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library spectrum, PsmFromTsv, and PsmFromTsvReader have been moved from MetaMorpheus to Mzlib.
The files have not yet been deleted in MetaMorpheus.
This pull request prepares the PsmReader to pass all tests in MetaMorpheus.
This pull request also fixes issues with reading in XL tsv files in Mzlib