Scan Filter in Averaged Spectra #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the MsDataScan constructor, replacing null values. This change ensures that the ScanFilter property is properly set, improving the accuracy and completeness of the scan data.
nbollis
added
bug
Maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
=======================================
Coverage 76.55% 76.55%
=======================================
Files 212 212
Lines 32011 32012 +1
Branches 3297 3297
=======================================
+ Hits 24507 24508 +1
Misses 6945 6945
Partials 559 559
|
zhuoxinshi
approved these changes
Oct 25, 2024
trishorts
approved these changes
Oct 29, 2024
RayMSMS
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SpectraFileAveraging.cs to include the ScanFilter parameter in the MsDataScan constructor, replacing null values. This change ensures that the ScanFilter property is properly set, improving the accuracy and completeness of the scan data.