Extended IBioPolymerWithSetMods interface, changed hashcodes #811
+35
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBioPolymerWithSetMods is used as a dictionary key in MetaMorpheus. However, as it doesn't implement an IEquatable interface, equality comparison is done by reference, instead of by calling the Equals method (I think).
This PR adds the IEquatable interface to the IBioPolymerWithSetMods interface.
The HashCode methods for classes that implement IBioPolymerWithSetMods are still the same. This is fine, as the Equals method is used to make the final determination of what is and is not a unique entry in a dictionary.