Upgrade dependencies and jdk to 21 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few minor code changes were made for the upgrade, including removing LspLog (which should have already been removed). I didn't make any larger changes to make use of java 21 features - that can be done later. The primary motivation of this commit is to update our dependency on lsp4j, which outdated and depended on a version of guava with two CVEs out: CVE-2023-2976, CVE-2020-8908. In order to do so, a jdk upgrade was required since newer versions of lsp4j are past jdk 8. We were going to upgrade the jdk soon anways.
hpmellema
reviewed
Jul 30, 2024
haydenbaker
approved these changes
Jul 30, 2024
Also got rid of an extra signing block in the publishing task, which is taken care of by jreleaser.
hpmellema
approved these changes
Jul 30, 2024
milesziemer
added a commit
to milesziemer/smithy-language-server
that referenced
this pull request
Jul 30, 2024
This version includes the same features as 0.3.0, but includes the JDK upgrade and lsp4j dependency upgrade from smithy-lang#157.
Merged
milesziemer
added a commit
that referenced
this pull request
Jul 30, 2024
This version includes the same features as 0.3.0, but includes the JDK upgrade and lsp4j dependency upgrade from #157.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor code changes were made for the upgrade, including removing LspLog (which should have already been removed). I didn't make any larger changes to make use of java 21 features - that can be done later. The primary motivation of this commit is to update our dependency on lsp4j, which outdated and depended on a version of guava with two CVEs out: CVE-2023-2976, CVE-2020-8908. In order to do so, a jdk upgrade was required since newer versions of lsp4j are past jdk 8. We were going to upgrade the jdk soon anways.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.