Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for setTrace and cancelProgress #183

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

milesziemer
Copy link
Contributor

Lsp4j provides default implementations of these methods in the LanguageServer interface, which throw exceptions. Even though we don't support this server side, better to give a warning than shutdown the server.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Lsp4j provides default implementations of these methods in the
LanguageServer interface, which throw exceptions. Even though we don't
support this server side, better to give a warning than shutdown the
server.
@milesziemer milesziemer requested a review from a team as a code owner December 18, 2024 20:14
@milesziemer milesziemer requested a review from sugmanue December 18, 2024 20:14
@milesziemer milesziemer requested review from yefrig and removed request for sugmanue December 18, 2024 20:14
@milesziemer milesziemer merged commit 5c9c72d into smithy-lang:main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants