Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip RestJsonDeserializeIgnoreType test, fix READMEs #189

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Skip RestJsonDeserializeIgnoreType test, fix READMEs #189

merged 2 commits into from
Nov 21, 2023

Conversation

haydenbaker
Copy link
Contributor

Description of changes:

  • New restJson1 protocol test was added for unions with __type here
  • We should specifically ignore this field (__type) for JSON based protocols instead of throwing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haydenbaker haydenbaker requested a review from a team as a code owner November 21, 2023 18:00
@JordonPhillips JordonPhillips merged commit 02df6cb into develop Nov 21, 2023
5 checks passed
@JordonPhillips JordonPhillips deleted the skip-restjson-test branch November 21, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordonPhillips JordonPhillips JordonPhillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haydenbaker @JordonPhillips