Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the @internal trait concerning ValidationException messages #2472

Open
hlbarber opened this issue Mar 16, 2023 · 1 comment
Open

Respect the @internal trait concerning ValidationException messages #2472

hlbarber opened this issue Mar 16, 2023 · 1 comment
Labels
bug Something isn't working server Rust server SDK

Comments

@hlbarber
Copy link
Contributor

This Smithy PR adds @internal to enum EnumString. We don't respect the semantics of @internal when considering constraint trait ValidationException messages and as a result, the PR updating to Smithy 1.28.1 causes the corresponding protocol tests to begin failing.
@hlbarber hlbarber added bug Something isn't working server Rust server SDK labels Mar 16, 2023
ysaito1001 added a commit that referenced this issue Apr 5, 2023
@ysaito1001
Add two protocol tests to the list of failing tests
632cfb3 
This commit adds two server protocol tests to the list of failing tests
due to #2472. They have
started failing as part of upgrading Smithy to a new version 1.29.0.
@david-perez
Copy link
Contributor

I think the Smithy spec should clarify here that this is indeed how the trait should be honored. My reading of the spec does not imply this. I opened a consultation: smithy-lang/smithy#1737.

@ysaito1001 ysaito1001 mentioned this issue Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@david-perez @hlbarber