-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to configure the default credentials cache #1220
Conversation
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
70c09f4
to
96deb3c
Compare
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some proposed docs improvements.
@@ -114,6 +114,71 @@ impl Builder { | |||
self | |||
} | |||
|
|||
/// Timeout for the given [`ProvideCredentials`] implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this say "default credentials chain"? We should clarify that this is the entire chain and not an individual provider (but maybe we should actually add that too...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Fixed.
/// Amount of time before the actual credential expiration time | ||
/// where credentials are considered expired. | ||
/// | ||
/// For example, if credentials are expiring in 15 minutes, and the buffer time is 10 seconds, | ||
/// then any requests made after 14 minutes and 50 seconds will load new credentials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should update to have a first line that can stand alone
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
A new generated diff is ready to view. |
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
Motivation and Context
This is for awslabs/aws-sdk-rust#462. It is just making it possible to change settings on the lazy caching builder used by the default credentials provider builder.
This should enable customizing the credential load timeout with:
Checklist
CHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.