Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Operation traits and structures #167

Merged
merged 12 commits into from
Jan 25, 2021
Merged

Http Operation traits and structures #167

merged 12 commits into from
Jan 25, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jan 20, 2021

Issue #, if available: #154, #169

Description of changes:
Initial implementation of Operation for HTTP based services and ParseHttpResponse. I'm also starting to collect design documentation in design, an mdBook intended to serve as a repository for public facing design documentation.

Although these are unused, they've gotten lots of milage in #107.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Initial implementation of `Operation` for HTTP based services and `ParseHttpResponse`. I'm also starting to collect design documentation in `design`, an mdBook intended to serve as a repository for public facing design documentation.
@rcoh rcoh requested a review from a team January 20, 2021 00:54
Co-authored-by: Jonathan Esterhazy <jonathan.esterhazy@gmail.com>
@rcoh rcoh requested a review from a team January 20, 2021 17:31
Copy link
Contributor

@krk krk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some typo nits.

design/src/operation.md Outdated Show resolved Hide resolved
design/src/operation.md Outdated Show resolved Hide resolved
design/src/operation.md Outdated Show resolved Hide resolved
design/src/operation.md Outdated Show resolved Hide resolved
rust-runtime/smithy-http/src/operation.rs Outdated Show resolved Hide resolved
rust-runtime/smithy-http/src/response.rs Outdated Show resolved Hide resolved
rust-runtime/smithy-http/src/operation.rs Outdated Show resolved Hide resolved
rcoh and others added 7 commits January 22, 2021 15:35
Co-authored-by: Kerem Kat <keremkat@gmail.com>
Co-authored-by: Kerem Kat <keremkat@gmail.com>
Co-authored-by: Kerem Kat <keremkat@gmail.com>
Co-authored-by: Kerem Kat <keremkat@gmail.com>
Co-authored-by: Kerem Kat <keremkat@gmail.com>
Co-authored-by: Kerem Kat <keremkat@gmail.com>
Co-authored-by: Kerem Kat <keremkat@gmail.com>
@rcoh rcoh requested a review from jesterhazy January 22, 2021 23:09
@rcoh rcoh merged commit 2ff12e6 into main Jan 25, 2021
@rcoh rcoh deleted the operation branch January 25, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants