Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DefaultEndpointResolver to the orchestrator #2577

Merged
merged 8 commits into from
Apr 17, 2023
Merged

Add DefaultEndpointResolver to the orchestrator #2577

merged 8 commits into from
Apr 17, 2023

Commits on Apr 13, 2023

  1. Add default endpoint resolver to the orchestrator 

    This commit adds `DefaultEndpointResolver` to the orchestrator. The type
implements the `EndpointResolver` trait and takes over the work previously
done by `make_operation` and `SmithyEndpointStage`.
    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    1e2efa7 View commit details
    Browse the repository at this point in the history

  2. Store default endpoint resolver and params builder 

    This commit places `DefaultEndpointResolver` and endpoint params builder
in the config bag from within `ServiceRuntimePlugin`. Notice we put a
builder, not endpoint params, because full construction of endpoint
params requires additional values to be set from an operation input,
which will later be handled by an interceptor.
    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    bf75cd7 View commit details
    Browse the repository at this point in the history

  3. Add endpoint params interceptors per operation 

    This commit generates interceptors for configuring endpoint params in the
orchestrator. There are two interceptors: one is to update params builder
with operation specific information, e.g. a bucket name, and the other is
to convert the params builder to the actual endpoint params by calling
`.build`.
    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    a23a547 View commit details
    Browse the repository at this point in the history

  4. Register interceptors for configuring endpoint params 

    This commit adds a codegen decorator to register interceptors to
`OperationRuntimePlugin`.
    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    3973f0f View commit details
    Browse the repository at this point in the history

  5. Use DefaultEndpointResolver in sra_test 

    This commit replaces `StaticUriEndpointResolver` with
`DefaultEndpointResolver` in `sra_test` to ensure the test continues to
work end-to-end.
    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ae25016 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into ysaito/default-ep-resolver-in-orc

    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f3b3d50 View commit details
    Browse the repository at this point in the history

  7. Derive Debug for types implementing ResolveEndpoint

    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0b4087a View commit details
    Browse the repository at this point in the history

  8. Allow clippy::useless_conversion conditionally 

    This commit allows the `clippy::useless_conversion` only when
`enableNewSmithyRuntime` is true. When we stop rendering an endpoint
prefix in `make_operation` after completingly switching over to the
orchestrator world, we can remove the attribute.
    @ysaito1001
    ysaito1001 committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    cb9b461 View commit details
    Browse the repository at this point in the history