-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add send_with method to fluent builders #2652
Merged
jdisanti
merged 60 commits into
smithy-lang:main
from
thomas-k-cameron:RFC30/add-set-fields
Jun 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
88b3c43
- Add feature gates
thomas-k-cameron 82d296c
Add CfgUnstable feature gate
thomas-k-cameron 5cc6ac9
add serde to runtime type
thomas-k-cameron 900cf67
Merge commit '82d296c38fa6794e7a986639d82456f1587b185f' into RFC30/ru…
thomas-k-cameron 72ed5b7
Merge commit '900cf67356e3d697cf2e330708e00810aa8665da' into RFC30/fe…
thomas-k-cameron f701ae1
add set field
thomas-k-cameron 78d2e0b
Merge commit '72ed5b78f1018e64095cfded1f5a9e756edff9ac' into RFC30/ad…
thomas-k-cameron 356bde7
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron c9a4ae0
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron 893692a
Update FluentClientGenerator.kt
thomas-k-cameron c2cce08
update
thomas-k-cameron 48c04f8
update
thomas-k-cameron bbd94ba
update
thomas-k-cameron 75e84e7
Update FluentClientGenerator.kt
thomas-k-cameron 7115727
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron ad8f413
update fluent client
thomas-k-cameron d1069dc
fix
thomas-k-cameron 2cb1e9b
update
thomas-k-cameron 663dff3
update
thomas-k-cameron 8b38afc
update
thomas-k-cameron 525f572
update
thomas-k-cameron e3367dd
update
thomas-k-cameron dc21f19
update
thomas-k-cameron 5972800
update
thomas-k-cameron 54a187b
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron e850ea2
update
thomas-k-cameron 8b2877e
update
thomas-k-cameron ca47afe
change input path
thomas-k-cameron 3bd1a7b
update
thomas-k-cameron a0a4651
update
thomas-k-cameron 299e5ec
FIX
thomas-k-cameron 605689e
updater
thomas-k-cameron ef38bbd
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron 857f3d4
FIX
thomas-k-cameron 7bd1365
asdf
thomas-k-cameron e5cd52f
update
thomas-k-cameron 7908333
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron 2e83422
update
thomas-k-cameron 212506c
update
thomas-k-cameron 54517f1
asdf
thomas-k-cameron 140c040
precommit
thomas-k-cameron 338ae8f
update
thomas-k-cameron edc62e8
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron 3d29cf9
asdf
thomas-k-cameron 7f44d06
Merge branch 'RFC30/add-set-fields' of https://github.com/thomas-k-ca…
thomas-k-cameron 6cd4b6b
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron 11af526
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron 8fc4751
Update codegen-client/src/main/kotlin/software/amazon/smithy/rust/cod…
thomas-k-cameron 20ea34b
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron ddc8c71
update
thomas-k-cameron 3531f10
update
thomas-k-cameron 08440b8
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron c76dada
Merge branch 'main' into RFC30/add-set-fields
jdisanti 79662af
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron 4251f97
update changelog
thomas-k-cameron 0e478b2
FIX
thomas-k-cameron fa6e681
update
thomas-k-cameron ef451bb
update
thomas-k-cameron d8c5135
Update CHANGELOG.next.toml
jdisanti 073d873
Merge branch 'main' into RFC30/add-set-fields
thomas-k-cameron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function will be just generally useful, so I would say let's remove the unstable attribute from it. May as well keep the supporting machinery around for your other PRs though.