Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC30: Refactoring blob #2850

Merged
merged 7 commits into from
Dec 20, 2023
+1 −3
Merged

RFC30: Refactoring blob #2850

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f35925
Rfc30/compiletime benchmark to ci (#22)
thomas-k-cameron Jul 4, 2023
535127e
update
thomas-k-cameron Jul 16, 2023
7882c7f
asdf
thomas-k-cameron Jul 16, 2023
0e5156f
Merge branch 'main' into RFC30/blob-fixing
thomas-k-cameron Jul 16, 2023
ff09b69
Merge branch 'main' into RFC30/blob-fixing
thomas-k-cameron Sep 6, 2023
f22893b
Merge branch 'main' into RFC30/blob-fixing
thomas-k-cameron Dec 7, 2023
58c5f21
Merge branch 'main' into RFC30/blob-fixing
thomas-k-cameron Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions rust-runtime/aws-smithy-types/src/blob.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ impl AsRef<[u8]> for Blob {
#[cfg(all(aws_sdk_unstable, feature = "serde-serialize"))]
mod serde_serialize {
use super::*;
use crate::base64;
use serde::Serialize;

impl Serialize for Blob {
Expand All @@ -54,7 +53,6 @@ mod serde_serialize {
#[cfg(all(aws_sdk_unstable, feature = "serde-deserialize"))]
mod serde_deserialize {
use super::*;
use crate::base64;
use serde::{de::Visitor, Deserialize};

struct HumanReadableBlobVisitor;
Expand All @@ -68,7 +66,7 @@ mod serde_deserialize {
where
E: serde::de::Error,
{
match base64::decode(v) {
match crate::base64::decode(v) {
Ok(inner) => Ok(Blob { inner }),
Err(e) => Err(E::custom(e)),
}
Expand Down
Loading