Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently handlers are constrained to
OperationShape::Input
toResult<OperationShape::Output, OperationShape::Error>
. This is overly prescriptive. As long as handler accepts, and returns types which serialize in compliance with the input, output, and error in the Smithy model then we are in compliance with the specification.This enables:
http::Response
.The change to
FromRequest<Ser, Op, B>
andIntoResponse<Ser, Op>
provides adherence to #2407, paving the way for reusable types.Description
OperationShape::Input
,OperationShape::Output
,OperationShape::Error
.FromRequest<Protocol, B>
toFromRequest<Ser, Op, B>
.IntoResponse<Protocol>
toIntoResponse<Ser, Op>
.FromRequest<Ser, Op, B>
and return typesIntoResponse<Ser, Op>
.struct FixInput
andtrait FixedService
as tools to remove the degree of freedom onUpgradePlugin
.