Only support T as an allowed separator in RFC-3339 dates #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
fahadzub/date-time-fix
branch
from
fea5899 to
d7cfb74
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Dec 4, 2024
| ("1985-04-12 23:20:50-02:00", AllowOffsets::OffsetsAllowed), | ||
| ("1985-04-12a23:20:50-02:00", AllowOffsets::OffsetsAllowed), | ||
| ]; | ||
| for (date, offset) in test_cases.into_iter() { |
There was a problem hiding this comment.
nit: these into_iter are unnecessary
ysaito1001
approved these changes
Dec 4, 2024
landonxjames
pushed a commit
that referenced
this pull request
Dec 5, 2024
This PR modifies `aws-smithy-types::DateTime` to enforce the use of 'T' (or 't') as the date-time separator. A [recent merge](https://github.com/time-rs/time/pull/700/files#diff-78a73b9911c88961601784e674a20c89e7050de9f8763522bbaa88ed28311b51R524) in the 'time' crate introduced support for space characters as separators. While ISO 8601 does allow spaces, RFC 3339 strictly requires 'T' (or 't') as the separator. This change restores the behavior to match how it was before `time = 0.3.37`. This PR also removes the temporary pinning of the time crate in protocol tests. Co-authored-by: Fahad Zubair <fahadzub@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
aws-smithy-types::DateTimeto enforce the use of 'T' (or 't') as the date-time separator. A recent merge in the 'time' crate introduced support for space characters as separators. While ISO 8601 does allow spaces, RFC 3339 strictly requires 'T' (or 't') as the separator.This change restores the behavior to match how it was before
time = 0.3.37.This PR also removes the temporary pinning of the time crate in protocol tests.