Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RDS #455

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Add support for RDS #455

merged 1 commit into from
Jun 3, 2021

Conversation

LMJW
Copy link
Contributor

@LMJW LMJW commented Jun 3, 2021

Issue #, if available:

Did not find a particular issue for supporting RDS, but I guess this is probably planned. If RDS support is not needed at the moment, I will close this pull request.

Description of changes:

Note, there is another rds-data smithy model. I will work on to add it if this PR is okay to merge.

Test:

  • ./gradlew :aws:sdk:assemble SUCCESS
  • ./gradlew :aws:sdk:test SUCCESS
  • ./gradlew :aws:sdk:cargoCheck SUCCESS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small things, but looks good. Thanks!

Comment on lines 14 to 15
# used only for static endpoint configuration:
http = "0.2.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# used only for static endpoint configuration:
http = "0.2.3"

(unused here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I will remove this dependency

@@ -0,0 +1,15 @@
[package]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename that file to just rds to match the other files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will update rds.2014-10-31.json tobe rds.json

@rcoh
Copy link
Collaborator

rcoh commented Jun 3, 2021

Fixes aws-sdk-rust#36

@LMJW
Copy link
Contributor Author

LMJW commented Jun 3, 2021

Hi @rcoh Please let me know if you have other comments. :)

@LMJW LMJW requested a review from rcoh June 3, 2021 14:52
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you please just confirm that you ran the example and it worked? (and at least 1 instance was printed). If you're not setup to test that easily just let me know and I can test on my computer before merging.

@LMJW
Copy link
Contributor Author

LMJW commented Jun 3, 2021

Yeah, it worked. Let me try recreate an instance and get the output quickly.

@LMJW
Copy link
Contributor Author

LMJW commented Jun 3, 2021

The example print out is

     Running `/Users/xxx/rust/smithy-rs/aws/sdk/build/aws-sdk/target/debug/rds-helloworld`
DB instance identifier: "test-m5"
DB instance class: "db.m5.large"
DB instance engine: "postgres"
DB instance status: "available"
DB instance endpoint: Endpoint { address: Some("test-m5.c6h6hf3yffse.us-east-1.rds.amazonaws.com"), port: 5432, hosted_zone_id: Some("Z2Rxxxxx") }

@rcoh rcoh merged commit c01245f into smithy-lang:main Jun 3, 2021
@LMJW LMJW deleted the rds branch June 5, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants