-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RDS #455
Add support for RDS #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small things, but looks good. Thanks!
# used only for static endpoint configuration: | ||
http = "0.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# used only for static endpoint configuration: | |
http = "0.2.3" |
(unused here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I will remove this dependency
@@ -0,0 +1,15 @@ | |||
[package] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rename that file to just rds
to match the other files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I will update rds.2014-10-31.json
tobe rds.json
Fixes aws-sdk-rust#36 |
Hi @rcoh Please let me know if you have other comments. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you please just confirm that you ran the example and it worked? (and at least 1 instance was printed). If you're not setup to test that easily just let me know and I can test on my computer before merging.
Yeah, it worked. Let me try recreate an instance and get the output quickly. |
The example print out is
|
Issue #, if available:
Did not find a particular issue for supporting RDS, but I guess this is probably planned. If RDS support is not needed at the moment, I will close this pull request.
Description of changes:
Note, there is another rds-data smithy model. I will work on to add it if this PR is okay to merge.
Test:
./gradlew :aws:sdk:assemble
SUCCESS./gradlew :aws:sdk:test
SUCCESS./gradlew :aws:sdk:cargoCheck
SUCCESSBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.