Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Route 53 Support #457

Merged
merged 13 commits into from
Jun 8, 2021
Merged

Add Route 53 Support #457

merged 13 commits into from
Jun 8, 2021

Conversation

alistaim
Copy link
Contributor

@alistaim alistaim commented Jun 3, 2021

Issue #, if available:

Description of changes:
The AWS CLI code constructs : https://route53.amazonaws.com/2013-04-01/hostedzonecount and the rust code constructs : https://route53.us-east-1.amazonaws.com/2013-04-01/hostedzonecount . This results in a hyper DNS error : Error: Unhandled(DispatchFailure(hyper::Error(Connect, ConnectError("dns error", Custom { kind: Other, error: "failed to lookup address information: nodename nor servname provided, or not known" }))))

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh
Copy link
Collaborator

rcoh commented Jun 8, 2021

@alistaim if you merge main this should work now

@rcoh
Copy link
Collaborator

rcoh commented Jun 8, 2021

Verified this works after #468 was merged

@rcoh rcoh changed the title R53 malformed url Add Route 53 Support Jun 8, 2021
@rcoh rcoh enabled auto-merge (squash) June 8, 2021 13:18
@rcoh rcoh merged commit 32949d6 into smithy-lang:main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants