Moved KMS code examples into KMS directory; added new KMS code examples #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
reviewed
Jun 10, 2021
|
|
||
| let conf = Config::builder().region(region).build(); | ||
| let conn = aws_hyper::conn::Standard::https(); | ||
| let client = Client::from_conf_conn(conf, conn); |
There was a problem hiding this comment.
I'm thinking we should have most of examples instantiate clients without customizing the connector, like this:
let config = Config::builder().region(region).build();
let client = Client::from_conf(config);
That should show people how to build a client quickly and easily without getting overloaded with details. At the same time, we should have an example somewhere with some good documentation on how to customize the HTTP connection, and maybe some concrete examples of why you would want to do that.
What do you think?
There was a problem hiding this comment.
I agree. I'll make the necessary changes and clear the "waiting-on-author" bit when I'm done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
KMS had only one code example, in the kms-helloworld directory.
Description of changes:
Moved the helloword code into the kms/src/bin directory; added another set of KMS code examples.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.