Moved QLDB code examples into qldb directory; added create-ledger code example #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Jun 11, 2021
|
|
||
| use aws_types::region::ProvideRegion; | ||
|
|
||
| //use qldbsession::model::StartSessionRequest; |
There was a problem hiding this comment.
Suggested change
| //use qldbsession::model::StartSessionRequest; |
| .unwrap_or_else(|| Region::new("us-west-2")); | ||
|
|
||
| if verbose { | ||
| println!("OLDB client version: {}\n", qldb::PKG_VERSION); |
There was a problem hiding this comment.
Suggested change
| println!("OLDB client version: {}\n", qldb::PKG_VERSION); | |
| println!("QLDB client version: {}\n", qldb::PKG_VERSION); |
There was a problem hiding this comment.
Good catch, changed.
| .send() | ||
| .await?; | ||
|
|
||
| match result.arn { |
There was a problem hiding this comment.
the result will always have an ARN, should probably unwrap here
| @@ -0,0 +1,79 @@ | |||
| /* | |||
rcoh
approved these changes
Jun 15, 2021
| @@ -1,4 +0,0 @@ | |||
| # QldbSession Hello World Example | |||
There was a problem hiding this comment.
can you bring back this readme?
…tly modified the description of the ledger in the hello world code example
Small language tweak suggesting the high level driver
rcoh
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
QLDB code examples were in separate directories.
Description of changes:
Moved all .RS files into qldb/src/bin; added create-ledger.rs.
Part of resolving issue #400.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.