Moved S3 code examples into s3 directory; added some S3 code examples #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
requested changes
Jun 11, 2021
| Some(objects) => { | ||
| // vector of Object items | ||
| println!("Objects:"); | ||
| for (_, x) in objects.iter().enumerate() { |
There was a problem hiding this comment.
I'm a little confused here, why get an index with .enumerate() but then just ignore it?
What about something like:
println!("Objects:");
for object in resp.contents.unwrap_or_default() {
println!(" {}", object.key.expect("objects have keys"));
}There was a problem hiding this comment.
Rookie mistake. Fixed.
rcoh
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Moved S3 .RS files into s3/src/bin; added a couple more code examples.
Description of changes:
Part of the resolution of issue #400.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.