Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 & fixes #495

Merged
merged 5 commits into from
Jun 11, 2021
Merged

EC2 & fixes #495

merged 5 commits into from
Jun 11, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jun 11, 2021

Description of changes:

  1. Adds python script to load latest models
  2. Load updated models for all services
  3. Add EC2 support
  4. Add EC2 boxed field customization & test.

Probably easiest to review commit-by-commit

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from jdisanti June 11, 2021 16:37
@rcoh rcoh changed the title Ec2 EC2 & fixes Jun 11, 2021
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


aws_models = sys.argv[1]

for model in os.listdir("aws-models"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a good idea to change directory into the script's directory just to be sure this will actually exist in case someone runs the script from the repository root.

@rcoh rcoh merged commit 14f435e into main Jun 11, 2021
@rcoh rcoh deleted the ec2 branch June 11, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants