Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HyperAdapter accessible #515

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Make HyperAdapter accessible #515

merged 2 commits into from
Jun 17, 2021

Conversation

zekisherif
Copy link
Contributor

Issue #, if available:
Was trying to use this earlier today to create my own connector and realized the hyper_impls module was private.

Description of changes:
Re-export HyperAdapter as Adapter

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh assigned jonhoo and rcoh Jun 17, 2021
@zekisherif
Copy link
Contributor Author

The module name hyper is conflicting with the hyper crate. Will rename it

jonhoo
jonhoo approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add some better documentation for this module + the adapter type too.

@jdisanti jdisanti merged commit 6482f0f into smithy-lang:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees

@jonhoo jonhoo

@rcoh rcoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zekisherif @jonhoo @jdisanti @rcoh