Customize S3's GetBucketLocation call to correctly parse the response #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
force-pushed
the
customize-get-bucket-location
branch
from
f44ee33
to
e622f8a
Compare
|
Full review coming tomorrow–instead of adding it as an integration test, add it to s3-tests.smithy. that will make it easier to upstream |
rcoh
approved these changes
Jun 18, 2021
| writeOperationWrapper(context) { tagName -> | ||
| parseStructureInner(members, builder = "builder", Ctx(tag = tagName, accum = null)) | ||
| if (outputShape.hasTrait<S3UnwrappedXmlOutputTrait>()) { | ||
| unwrappedResponseParser("builder", "decoder", "start_el", outputShape.members()) |
There was a problem hiding this comment.
is there a reason you didn't just call parseStructureInner here? You could still validate the one member constraint here if you wanted
There was a problem hiding this comment.
Yes, parseStructInner calls parseLoop which advances to the next tag (which won't exist in this case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom Smithy trait to customize the XML deserialization codegen for S3's GetBucketLocation call to fix aws-sdk-rust#116.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.