Updated SageMaker examples to take a region arg; added doc comments. #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
requested changes
Jun 21, 2021
Comment on lines
64
to
71
| let deets = format!( | ||
| "{}\t{}\t{}\t{:#?}", | ||
| name, | ||
| creation_time.format("%Y-%m-%d@%H:%M:%S"), | ||
| duration.num_seconds(), | ||
| status | ||
| ); | ||
| println!("{}", deets); |
There was a problem hiding this comment.
You can combine these two lines:
println!(
"{}\t{}\t{}\t{:#?}",
name,
...
);
Comment on lines
59
to
63
| let details = format!( | ||
| "Notebook Name : {}, Notebook Status : {:#?}, Notebook Instance Type : {:#?}", | ||
| n_name, n_status, n_instance_type | ||
| ); | ||
| println!("{}", details); |
jdisanti
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
SageMaker code examples had no doc comments.
Description of changes:
Added them and an optional command-line region arg (-d DEFAULT-REGION).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.